Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the broken TOX_VERSION_REQUIRE macro. #328

Merged
merged 1 commit into from
Dec 16, 2016
Merged

Drop the broken TOX_VERSION_REQUIRE macro. #328

merged 1 commit into from
Dec 16, 2016

Conversation

GrayHatter
Copy link

@GrayHatter GrayHatter commented Dec 14, 2016 •
edited by iphydf
Loading

Closes #327

This change is Reviewable

@iphydf iphydf added this to the v0.1.1 milestone Dec 14, 2016
@nurupo
Copy link
Member

nurupo commented Dec 15, 2016

@iphydf do we want to remove the TOX_VERSION_REQUIRE macro or fix it and keep it?

@iphydf
Copy link
Member

iphydf commented Dec 15, 2016

Let's remove it. Nobody uses it, and people can use the preprocessor to require it anyway.

@iphydf iphydf changed the title Drop an Unworking Macro Drop the broken TOX_VERSION_REQUIRE macro. Dec 15, 2016
@nurupo
Copy link
Member

nurupo commented Dec 16, 2016

:lgtm_strong:

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@iphydf iphydf merged commit 4dccd66 into TokTok:master Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nurupo nurupo

Labels
None yet
Projects
None yet
Milestone
v0.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@GrayHatter @nurupo @iphydf